Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api4 - Make abstract function abstract #16343

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Api4 - Make abstract function abstract #16343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Civi/Api4/Generic/AbstractEntity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,9 @@ public static function getActions() {
}

/**
* Should return \Civi\Api4\Generic\BasicGetFieldsAction
* @todo make this function abstract when we require php 7.
* @throws \Civi\API\Exception\NotImplementedException
* @return \Civi\Api4\Generic\BasicGetFieldsAction
*/
public static function getFields() {
throw new NotImplementedException(self::getEntityName() . ' should implement getFields action.');
}
abstract public static function getFields();

/**
* Returns a list of permissions needed to access the various actions in this api.
Expand Down