Start to use function rather than multiple queries for event details add test #16329

eileenmcnaughton · 2020-01-18T06:27:28Z

Overview

Minor code cleanup

Details from event retrieved as needed (sql queries)

Once event is retrieved it is cached for re-use. Test added

civibot · 2020-01-18T06:27:30Z

(Standard links)

If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

tests/phpunit/CRM/Event/Form/ParticipantTest.php

mattwire · 2020-01-18T12:27:51Z

@eileenmcnaughton You're only using the cached function in one place but I assume the plan is to follow up with more usage?

eileenmcnaughton · 2020-01-18T22:06:58Z

… add test

civibot bot added the master label Jan 18, 2020

mattwire reviewed Jan 18, 2020

View reviewed changes

tests/phpunit/CRM/Event/Form/ParticipantTest.php Outdated Show resolved Hide resolved

Start to use function rather than multiple queries for event details,…

f84f92f

… add test

eileenmcnaughton force-pushed the ev_one branch from 8812472 to f84f92f Compare January 18, 2020 22:07

mattwire added the merge on pass label Jan 18, 2020

eileenmcnaughton merged commit 594e096 into civicrm:master Jan 18, 2020

eileenmcnaughton deleted the ev_one branch January 18, 2020 23:25