Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Code cleanup #16314

Merged
merged 2 commits into from
Jan 17, 2020
Merged

[NFC] Code cleanup #16314

merged 2 commits into from
Jan 17, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Declare exceptions, strict comparisons, single quotes where possible

Before

After

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jan 17, 2020

(Standard links)

@civibot civibot bot added the master label Jan 17, 2020
@colemanw
Copy link
Member

Looks good.
Retest this please

@seamuslee001 seamuslee001 merged commit ee3dc25 into civicrm:master Jan 17, 2020
@seamuslee001 seamuslee001 deleted the nfc branch January 17, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @colemanw @seamuslee001