Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Code cleanup #16309

Merged
merged 1 commit into from
Jan 17, 2020
Merged

[NFC] Code cleanup #16309

merged 1 commit into from
Jan 17, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

  • Throw exception rather than fatal
  • declare exceptions
  • single quotes
  • strict comparisons

Before

Use of fatal, unnecessary double quotes, exceptions not declared

After

Above remedied

Technical Details

Comments

@eileenmcnaughton
[NFC] Code cleanup
a02672c 
Throw exception rather than fatal
- declare exceptions
- single quotes
- strict comparisons
@civibot
Copy link

civibot bot commented Jan 17, 2020

(Standard links)

@civibot civibot bot added the master label Jan 17, 2020
@eileenmcnaughton eileenmcnaughton merged commit 5286810 into civicrm:master Jan 17, 2020
@eileenmcnaughton eileenmcnaughton deleted the gn branch March 18, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001