[REF] Remove apparent copy & paste code. #16308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In code familiarisation to tackle dev#core/1217 I looked at this var & concluded that the var is set in 9 places but in 8 of those it is never used. In the last place (CRM_Contact_Form_Search) it is used to determine whether to build the pre-next cache. I swapped it over to just doing a getButton without any change - I stepped through in advanced search, search builder, custom search, basic search it still enters the cache lines of code. In Contribution, event search it doesn't (before & after). Part of just makingg code semi-readable
|
(Standard links)
|
|
Gotta love copy-paste. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes a property that is set much more often than it is used
Before
All search forms have apparent copy & paste to set $this->_searchButtonName
After
Property removed, the one place it is used just calls getButtonName
Technical Details
In code familiarisation to tackle dev#core/1217 I looked at this var & concluded that the var is set in 9 places but in 8 of those it is never used. In the last place (CRM_Contact_Form_Search) it is used to determine whether to build the pre-next cache/ whether this is an 'original search'. I swapped it over to just doing a getButton without any
change - I stepped through in advanced search, search builder, custom search, basic search it still enters the cache lines of code. In Contribution, event search it doesn't (before & after).
Part of just making code semi-readable
Comments