Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move handling of default payment instrument for a payment proc… #16279

Merged

Conversation

seamuslee001
Copy link
Contributor

…essor into the create function from API and expand tests

Overview

This moves the handling for the payment_instrument_id field for payment processors out of the API layer into the BAO create function so can be used by APIv4 as well

Before

Setting payment instrument id occurs in API Layer

After

Setting payment instrument id occurs in BAO Layer

ping @colemanw @eileenmcnaughton

…essor into the create function from API and expand tests
@civibot
Copy link

civibot bot commented Jan 11, 2020

(Standard links)

@colemanw
Copy link
Member

Looks great!

@colemanw colemanw merged commit 0a5024a into civicrm:master Jan 11, 2020
@eileenmcnaughton eileenmcnaughton deleted the ref_payment_processor_instrument branch January 12, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants