[REF] Fix CRM_Core_BAO_UFGroup::createUFJoin to not receive by reference.

[eileenmcnaughton]

Overview

Minor code cleanup - stop passing variable by reference, pass actually required values

Before

public static function createUFJoin(&$params, $ufGroupId) {

After

public static function createUFJoin($params, $ufGroupId) {

In addition a small array containing only the 2 params used by the function is passed to it, getting away from 're-using' $params

Technical Details

This function is called from one place. It gets passed a params variable that is 're-used' so this
change makes it clear what actually needs to be passed on. We have an anti-pattern in our code whereby params get
passed all sorts of places with it being confusing which ones actually need to receive what

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[colemanw]

If only 2 variables are needed, I would vote for having them be function params, e.g.

CRM_Core_BAO_UFGroup::createUFJoin($ufGroupId, $ufGroupType, $weight)

[eileenmcnaughton]

@colemanw fixed

[eileenmcnaughton]

@colemanw see above for changes you suggested

[jitendrapurohit]

I've just tested this manually and looks fine to me. Confirmed that the function is called only from CRM/UF/Form/Group.php and the new parameters work fine in storing the values to the database. +1 to merge this change.

[eileenmcnaughton]

Thanks @jitendrapurohit