Add tax rates to metadata #16253
Merged
Add tax rates to metadata #16253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
reviewed
Jan 9, 2020
This doesn't do anything by itself but it lays the foundation for a solid fix for civicrm#15895 - ie by having minimum_fee_with_tax as part of our generally available metadata we get out of all the complexity of doing this in the js layer - which is what is driving that bug
eileenmcnaughton
force-pushed
the
mem_val2
branch
from
42da17f to
49bbb50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This doesn't do anything by itself but it lays the foundation for a solid fix for
#15895 - ie by having minimum_fee_with_tax as part of our
generally available metadata we get out of all the complexity of doing this in the js layer - which is what is driving that bug
Before
value for minimum_fee_with_tax for a membership type not easily available in the php layer. It is calculated (badly) in the js layer
After
Centralised cached function includes this calculated value
Technical Details
Comments