Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Test update following PR #16150, assertEquals first param is th… #16219

Merged
merged 1 commit into from
Jan 7, 2020
Merged

[NFC] Test update following PR #16150, assertEquals first param is th… #16219

merged 1 commit into from
Jan 7, 2020

Conversation

seamuslee001
Copy link
Contributor

…e expected value not the current value

Overview

Updates the assertEquals function call such that it is more sensible as per @demeritcowboy #16150 (comment)

Before

Test function params around the wrong way

After

Test function params around the correct way

ping @eileenmcnaughton @demeritcowboy

@seamuslee001
[NFC] Test update following PR civicrm#16150, assertEquals first para…
9b4b005 
…m is the expected value not the current value
@civibot
Copy link

civibot bot commented Jan 7, 2020

(Standard links)

@civibot civibot bot added the master label Jan 7, 2020
@demeritcowboy
Copy link
Contributor

Looks good.

@seamuslee001 seamuslee001 merged commit 050abb2 into civicrm:master Jan 7, 2020
@seamuslee001 seamuslee001 deleted the nfc_test_followup_16150 branch January 7, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @demeritcowboy @colemanw