dev/core#1143 enable auto adding of backticks when doing an insert() or update() function

[seamuslee001]

Overview

To support MySQL 8 there are a number of new reserved words such as grouping which need to be handled sensibly when inserting or updating or querying data. This change will when we do a create api call or similar that the DB_DataObject automatically adds backticks around the table field names and values which stops issues

Before

CRM_Core_BAO_MappingTest fails on MySQL8

After

CRM_Core_BAO-MappingTest passes on MySQL 8

ping @eileenmcnaughton @monishdeb @JoeMurray @totten

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 this looks promising & probably we should have done it a long time ago given some bugs we've had around location table names in queryObject. Have you dug into how it actually works? The fact tests pass give me quite a bit of confidence....

[seamuslee001]

@eileenmcnaughton basically what happens is that as far as i know for us is that when we call insert() or update() or delete() e,g, from https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/DAO.php#L543 that this https://github.com/civicrm/civicrm-packages/blob/master/DB/DataObject.php#L1074 is now true which then means it calls the quoteIdentifiers function in DB/mysqli.php here https://github.com/civicrm/civicrm-packages/blob/master/DB/DataObject.php#L1150 to wrap it in a backtick it also triggers quoting of the table name as well https://github.com/civicrm/civicrm-packages/blob/master/DB/DataObject.php#L1239

[eileenmcnaughton]

@seamuslee001 I'm inclined to this that so many tests go through here we can rely on that. Also this is at the start of the rc cycle so it gets 2 full months - I'm going to merge this