dev/drupal#98 Fix masquerade issue caused by drupal update change #16177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Comments in gitlab by @totten & @kcristiano both support merging early in the cycle (ie with a full month pre rc + rc) so I'm merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix for breakage in masquerade caused by drupal update https://www.drupal.org/files/issues/2019-11-04/3025335-51.patch
Before
Refer https://lab.civicrm.org/dev/drupal/issues/98
After
Technical Details
Comments
PR is a bit light on details as I have just converted the submitted patch to a PR - it seems to make sense to me but have not replicated or tested