Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Clean up unit test #16163

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Cleanup on unit test class

Before

Duplication, uses Membership::create passing deprecated $ids

After

Duplication swapped to extracted function. Switched to calling api rather than Membership::create directly

Technical Details

Removes duplication (including one test entirely covered by other tests. Switches to using api create
and removes passing in of as part of goal to eliminate this

Comments

Anything else you would like the reviewer to note

@civibot
Copy link

civibot bot commented Dec 30, 2019

(Standard links)

Removes duplication (indluding one test entirely covered by other tests. Switches to using api create
and removes passing in of  as part of goal to eliminate this
@seamuslee001 seamuslee001 merged commit e356d6f into civicrm:master Dec 30, 2019
@seamuslee001 seamuslee001 deleted the mod_member branch December 30, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants