Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleanup on unit test class
Before
Duplication, uses Membership::create passing deprecated $ids
After
Duplication swapped to extracted function. Switched to calling api rather than Membership::create directly
Technical Details
Removes duplication (including one test entirely covered by other tests. Switches to using api create
and removes passing in of as part of goal to eliminate this
Comments
Anything else you would like the reviewer to note