dev/core#1489 do not reconcile managed entities whilst in upgrade mod…

[seamuslee001]

…e and add in a step at the end of the upgrade process to reconcile managed entiies and add in civicrm_permissions hook to the whitelist of upgrade friendly hooks

Overview

This adds in code to ensure we do not reconcile managed entities until after the upgrade is run and also adds in the civicrm_permissions hook to the whitelist as i don't think that can be problematic

Before

Managed entities maybe reconciled during upgrade

After

Managed entities are not reconciled during upgrade

ping @eileenmcnaughton @totten @jusfreeman

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

style warning

[eileenmcnaughton]

OK - this makes sense - let's get it merged before the next rc is cut

[arborrow]

FYI, when upgrading to 5.22.0 I received the following:
There is a Payment Processor associated with selected Payment Processor type, hence it can not be deleted.

And then later, I saw:
Sorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred. API error: Could not delete payment processor type

It appears that the upgrade succeeds so I am hoping that all is well. I only have Stripe enabled on the site.

[arborrow]

I was able to disable and re-enable CiviDiscount without issue so as best I can tell all is well.