Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch static var to using Civi::statics #16138

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 22, 2019

Overview

Switches a static var from in-function to using civi statics

Before

static var in function

After

Using Civi statics for static function

Technical Details

This static variable is actually problematic. Moving it to statics will allow us to stop reseting it
in the test suite & to hone in on where it is actually broken rather than the test suite
is not flushing it

Comments

@civibot civibot bot added the master label Dec 22, 2019
@civibot
Copy link

civibot bot commented Dec 22, 2019

(Standard links)

This static variable is actually problematic. Moving it to statics will allow us to stop reseting it
in the test suite & to hone in on where it is actually broken rather than the test suite
is not flushing it
@eileenmcnaughton
Copy link
Contributor Author

Note this is mergeable as is but I'm looking at fully removing the static in #16139 - still good to merge this in the meantime in case that stalls

@mattwire mattwire merged commit 6c97b63 into civicrm:master Dec 22, 2019
@eileenmcnaughton eileenmcnaughton deleted the static branch December 22, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants