Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Test clean up. #16133

Merged
merged 1 commit into from
Dec 22, 2019
Merged

[NFC] Test clean up. #16133

merged 1 commit into from
Dec 22, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Code cleanup on processMembership test

Before

Very hard to see what test is doing

After

Less code repetition, use of array

Technical Details

Good test - nightmare to read. This helps.

Comments

@civibot
Copy link

civibot bot commented Dec 21, 2019

(Standard links)

@civibot civibot bot added the master label Dec 21, 2019
@eileenmcnaughton eileenmcnaughton force-pushed the member_test branch 2 times, most recently from 67a4c06 to 998d719 Compare December 21, 2019 22:55
@eileenmcnaughton
[NFC] Test clean up.
8545826 
Good test - nightmare to read. This helps.
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001 seamuslee001 merged commit 2ca9b2e into civicrm:master Dec 22, 2019
@seamuslee001 seamuslee001 deleted the member_test branch December 22, 2019 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001