[Ref] Remove php4 support from BAO_Acl class #16119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes instances of php support involving & in the function signature. In each instance the function is only ever called once (I think all are internal too) & the calling function doesn't do any weird stuff with references that might make it needed. Also remove one instance of unnecessarily passed by ref
|
(Standard links)
|
| @@ -78,8 +78,6 @@ public static function operation() { | |||
| /** | |||
| * Construct a WHERE clause to handle permissions to $object_* | |||
| * | |||
| * @deprecated | |||
There was a problem hiding this comment.
still in the same comment block - just lower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code tidy up for readability - remove confusing legacy php support structures
Before
Function calls like
public static function &getGroupACLs($contact_id, $aclRoles = FALSE) {After
Function calls like
public static function getGroupACLs($contact_id, $aclRoles = FALSE) {Technical Details
Removes instances of php support involving & in the function signature. In each instance the function is only ever called once
(I think all are internal too) & the calling function doesn't do any weird stuff with references that might make it needed.
Also remove one instance of unnecessarily passed by ref
Comments