dev/core#1477 Fix fatal error when editing reserved option group settings #16106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@demeritcowboy are you able to put this against the 5.21 branch please, Agree with this |
|
Oh right. Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/issues/1477
When visiting /civicrm/admin/options if you try to edit the settings for reserved option group you get a fatal error.
Before
Network Error
Unable to reach the server. Please refresh this page in your browser and try again.
After
Can eat dinner without popups.
Technical Details
It looks like in #15937 the
nametextbox was removed from the form but it tries to "freeze" it later if the option group is reserved.