dev/core#711 remove Google+ #16099
Merged
dev/core#711 remove Google+ #16099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@agileware-pengyi Is that all the references in the codebase? |
|
Looks like there are references to it in |
agileware-pengyi
force-pushed
the
CIVICRM-1243
branch
from
d9ad8c5 to
8dd03f6
Compare
|
@seamuslee001 @yashodha I've updated the branch. |
|
@agileware-pengyi thanks! |
colemanw
reviewed
Dec 26, 2019
| @@ -740,7 +740,6 @@ VALUES | |||
| (@option_group_id_website, 'Work', 1, 'Work', NULL, 0, 1, 1, NULL, 0, 0, 1, NULL, NULL, NULL), | |||
| (@option_group_id_website, 'Main', 2, 'Main', NULL, 0, NULL, 2, NULL, 0, 0, 1, NULL, NULL, NULL), | |||
| (@option_group_id_website, 'Facebook', 3, 'Facebook', NULL, 0, NULL, 3, NULL, 0, 0, 1, NULL, NULL, NULL), | |||
| (@option_group_id_website, 'Google+', 4, 'Google_', NULL, 0, NULL, 4, NULL, 0, 0, 1, NULL, NULL, NULL), | |||
There was a problem hiding this comment.
Upgrade SQL needed to remove this.
1 similar comment
|
I'm going to merge this - the upgrade PR can follow but I don't think it blocks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I am trying to push this forward, so here is PR for removing Google+ icon from the social network template.
Before
Google+ reference included
After
Google+ reference removed
Comments
Agileware ref: CIVICRM-1243