dev/core#1463 Fix record payment form errors

[jitendrapurohit]

Overview

1. Record Payment form does not load.
2. Record payment fails when Amount Owed is a decimal point number. Eg 264.65

Before

1. Register a contact for an event with Fee Amount = $264.65.
2. Keep the status as Partially Paid and pay only part of the above amount. Eg 100. Amount owed = $164.65.
3. Save.
4. Click "Record Payment" and try to pay the remaining amount. The form does not load which seem to be a regression from [REF] remove call to deprecated function #15465

1. Select payment method and click save.

After

Form loads fine and accept the decimal amount as it is equal to the remaining amount that needs to be paid.

Comments

This isn't included in 5.20 released tarball but occurs in the 5.21 rc version. Probably, the first issue needs an rc fix? Hence an rc PR.

Gitlab - https://lab.civicrm.org/dev/core/issues/1463

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jitendrapurohit]

According to https://lab.civicrm.org/dev/core/issues/1463#note_28671, maybe, the complete check should be removed? Hmm, but that might add some more discussion as what needs to be done to the main contribution amount when the form is submitted with > owed amount?

[eileenmcnaughton]

@jitendrapurohit so 5.20 does NOT have the regression?

[jitendrapurohit]

Ah, all our sites are on 5.20.0 so didn't realise 5.20.1 is out and having this regression in it.

Yes, it's included in 5.20.1. Do you want me to push an rc fix against it?

[eileenmcnaughton]

5.21 is the rc - but yes let's do in 5.20 too - I can see some cleanups to do but this is fine for the rc & we can fix up in master - there are likely already PRs for that in master anyway

[jitendrapurohit]

done #16073