Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Refactor Campaign Search form to use standardised getSortID fun… #16055

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

seamuslee001
Copy link
Contributor

…ction

Overview

Minor refactor to campaign search form to use a consolidated function to get the sort id

Before

Duplicated code in search form class used to get sort id

After

Centralised standardised functon used to get the sort id

ping @demeritcowboy @eileenmcnaughton

@civibot
Copy link

civibot bot commented Dec 9, 2019

(Standard links)

@civibot civibot bot added the master label Dec 9, 2019
@eileenmcnaughton
Copy link
Contributor

This is the campaign dashboard isn't it? If so searches still work fine there with this patch

/civicrm/campaign?reset=1&subPage=campaign

@seamuslee001
Copy link
Contributor Author

yes AFAIK

@eileenmcnaughton eileenmcnaughton merged commit 4c0d3f5 into civicrm:master Dec 9, 2019
@eileenmcnaughton eileenmcnaughton deleted the campaign_sort branch December 9, 2019 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants