Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Refactor Activity Search to use parent getSortID function #16053

Merged
merged 1 commit into from
Dec 9, 2019
Merged

[REF] Refactor Activity Search to use parent getSortID function #16053

merged 1 commit into from
Dec 9, 2019

Conversation

seamuslee001
Copy link
Contributor

Overview

Very minor refactor to the activity search

Before

Uses duplicated code to achieve sort result

After

Uses core function to achieve sort result

ping @demeritcowboy @eileenmcnaughton

@civibot
Copy link

civibot bot commented Dec 9, 2019

(Standard links)

@civibot civibot bot added the master label Dec 9, 2019
@eileenmcnaughton
Copy link
Contributor

Looks good - we did this on the other forms

@eileenmcnaughton eileenmcnaughton merged commit f110af5 into civicrm:master Dec 9, 2019
@eileenmcnaughton eileenmcnaughton deleted the activity_sort branch December 9, 2019 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton