[NFC] Add in a unit test of passing an array into the Civi::settings … #16045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set facade and getting it back
|
(Standard links)
|
|
|
||
| $manager = $this->createManager()->useDefaults(); | ||
| $dSettings = $manager->getBagByDomain($domain->id); | ||
| $dSettings->set('test_setting', ['hello' => 'World']); |
There was a problem hiding this comment.
I merged this but since there is not metadata for test_setting it should have failed with a deprecation notice IMHO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…set facade and getting it back
ping @eileenmcnaughton this might just be a starting point but its something