Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused cancelledStatus assign on contributionView #16019

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Remove unused cancelledStatus assign on contributionView #16019

merged 1 commit into from
Dec 3, 2019

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Dec 3, 2019

Overview

Remove unused code per comments

Before

Unused code

After

Code gone

Technical Details

Comments

Confirmed that this is not used.

@civibot
Copy link

civibot bot commented Dec 3, 2019

(Standard links)

@civibot civibot bot added the master label Dec 3, 2019
@seamuslee001
Copy link
Contributor

Looks like those comments were added 4 years ago 99cdd94#diff-ea2b23fdc8af3f7a0cdb0420d44e1239R67 and i trust Matt and Eileen and tests have passed and my own grep suggests it can go merging

@seamuslee001 seamuslee001 merged commit 7232cf4 into civicrm:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwire @seamuslee001