Add function to set entitySubType for entity forms #16017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test this please |
mattwire
force-pushed
the
setentitysubtype
branch
from
b2067d7 to
ed706f8
Compare
mattwire
added
the
merge ready
| @@ -179,7 +179,6 @@ | |||
| {if $action eq 4} | |||
| {include file="CRM/Custom/Page/CustomDataView.tpl"} | |||
| {else} | |||
| <div id="customData"></div> | |||
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
OK - I can see it duplicated in the include file. I'm not wild about it being included with an unrelated change without notes but I think it makes sense.
|
Tested & creating a case with custom data associated with a case type still works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I originally added the functions and comments for this and it's only use on the case form. But the way I did it doesn't make sense to me! This makes it actually useful. Most forms actually load the custom data via javascript so never actually use the subtype at the form level - I'm doing some work on civibooking and converting that to entityform requires a specific activity type.
Before
Not possible to set the entity subtype on an entity form.
After
Entity subtype can be set in a standard way and is used if set.
Technical Details
Implement
setEntitySubType()and check ifgetEntitySubType()method exists before using it.Comments
@eileenmcnaughton As the resident entityform expert would you be able to take a look?