Fix activity search to work by url params

[eileenmcnaughton]

Overview

Fixes activity search for url params

Before

civicrm/activity/search?reset=1&force=1&activity_date_time_high=20180101 does not apply a filter

After

civicrm/activity/search?reset=1&force=1&activity_date_time_high=20180101 applies a filter

Technical Details

It seems to be missing the call to the parent fn

Note I feel like the parent should also handle some of the rows below in future

Comments

@seamuslee001 in response to your comment here #15942 (comment)

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

The parent fn doesn't seem to do these rows - but should

[seamuslee001]

Agreed on that

[seamuslee001]

@eileenmcnaughton should we remove L195 as well?

[seamuslee001]

@eileenmcnaughton just performed an r-run on this

Date field works perfectly
trying to use activity_text you can but get an e-notice
the sort_name param doesn't seem to do anything

[seamuslee001]

@eileenmcnaughton this fixes the e-notice for me when using &activity_text=xxx

diff --git a/CRM/Activity/BAO/Query.php b/CRM/Activity/BAO/Query.php
index 3f2758b838..d9397a5cd9 100644
--- a/CRM/Activity/BAO/Query.php
+++ b/CRM/Activity/BAO/Query.php
@@ -457,6 +457,9 @@ class CRM_Activity_BAO_Query {
       'title' => ts('Activity Text'),
       'type' => CRM_Utils_Type::T_STRING,
       'is_pseudofield' => TRUE,
+      'html' => [
+        'type' => 'Text',
+      ],
     ];
     return $metadata;
   }

[eileenmcnaughton]

@seamuslee001 done

[eileenmcnaughton]

test this please

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass
  • (r-doc) Pass
  • (r-run) Pass tested this and confirmed it works as expected and no e-notices are generated
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass