dev/report#23 - Fix contact sub-type 'is not one of' filtering #15971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
When filtering by contact sub-type using 'is not one of' do not exclude where sub-type is null. Add unit tests for contact sub-type 'is one of' and 'is not one of' Tighten the matching on sub-type to avoid problems where one contact sub-type is a substring of another.
|
Thanks! This patch worked for me. |
|
Merging based on:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When filtering by contact sub-type using 'is not one of' do not exclude where sub-type is null.
Before
When filtering by contact sub-type in a report using 'is not one of', only contacts with a sub-type are returned. For example, 'is not one of' 'Student' excludes Students and all those with no sub-type.
After
Contacts with no sub-type are included, so the only ones excluded are the Students.
Technical Details
This adds unit tests for contact sub-type 'is one of' and 'is not one of'.
It also tightens the matching on sub-type to avoid problems where one contact sub-type is a substring of another.
Comments
See also https://lab.civicrm.org/dev/report/issues/23
https://lab.civicrm.org/dev/report/issues/15#note_25491