dev/drupal#85 Drupal8: Fix bug with empty language prefix mangling https:// to http:/

[dsnopek]

Overview

On a Drupal 8 multilingual site, if you are using URL "Path prefix" language negotiation, and set one of the prefixes to empty (so, for that language, there is no prefix), then CiviCRM resource URLs will get mangled to be "https:/" (one slash) instead of "https://" (two slashes)

Here's what the config would look like:

Before

On CiviCRM pages, it's trying to load CSS and JS from URLs like "https:/example.org" (one slash) rather than "https://example.org" (two slashes)

After

The right URL gets used!

Technical Details

The problem is in CRM_Utils_System_Drupal8::languageNegotiationURL():

            if ($removeLanguagePart) {
              $url = str_replace("/" . $config['prefixes'][$language] . "/", '/', $url);
            }

If $config['prefixes'][$language] is an empty string, then we end up with str_replace("//", "/", $url) which is taking the double slash in "https://" and turning it into "https:/"

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This looks fine to me @totten ?

[totten]

Looks reasonable to me (though I don't use language prefixes, so I'm weak to the power of suggestion 🙃).

[mlutfy]

This seem to fix: https://lab.civicrm.org/dev/drupal/issues/85

I'm a bit behind in my upgrades and would need time to test, but the patch makes sense.

Could we backport to 5.20-rc? It's not a recent regression, but a few people had complained about this bug.

[seamuslee001]

@mlutfy have you had a chance to test this?

[mlutfy]

I couldn't replicate the issue, but the code makes sense. I did a bit more testing and didn't see any impact. Thanks @dsnopek !