Fix CRM_Contribute_BAO_ContributionTest to no longer use unreliable legacy set up method #15905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improvement to test class to not use (buggy & deprecated) partial_amount_to_pay params & use Order.create + Payment,create
Before
Bad method called to set up for test - contribution created with status = 'Partially Paid' & no financial trxns
After
Better (not quite preferred since we are still using Contrribution not Order) method used. Since the test is still fixing legacy-flow functions we then have to hack out some of the correctly created data to replicate things being done badly.
Technical Details
The whole partial_amount_to_pay params thing works badly & was actually the cause of other fixes stalling for 6 months.
This is part of an effort to deprecate & eliminate it
Comments