Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRM_Contribute_BAO_ContributionTest to no longer use unreliable legacy set up method #15905

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Improvement to test class to not use (buggy & deprecated) partial_amount_to_pay params & use Order.create + Payment,create

Before

Bad method called to set up for test - contribution created with status = 'Partially Paid' & no financial trxns

After

Better (not quite preferred since we are still using Contrribution not Order) method used. Since the test is still fixing legacy-flow functions we then have to hack out some of the correctly created data to replicate things being done badly.

Technical Details

The whole partial_amount_to_pay params thing works badly & was actually the cause of other fixes stalling for 6 months.

This is part of an effort to deprecate & eliminate it

Comments

…egacy set up method

The whole partial_amount_to_pay params thing works badly & was actually the cause of other fixes stalling for 6 months.

This is part of an effort to deprecate & eliminate it
@civibot
Copy link

civibot bot commented Nov 21, 2019

(Standard links)

@civibot civibot bot added the master label Nov 21, 2019
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 this should be straight forward

@seamuslee001
Copy link
Contributor

Changes make sense only changes in non tests files are to comments only which i agree with, changes in tests look good and Jenkins has passed it merging

@seamuslee001 seamuslee001 merged commit b9681fe into civicrm:master Nov 21, 2019
@seamuslee001 seamuslee001 deleted the test_good branch November 21, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants