Enforce isSkipLineItem for membership payment entity in Order.create

[mecachisenros]

Overview

Enforce isSkipLineItem for membership payment entity in the Order.create API to prevent error on line item update. The line items are already correctly created by the time the membership payment is created so there's no need to update.

Before

Creating an Order with two or more memberships (and using a Price field with a membership type set) will trigger an error when creating the MembershipPayment entity.

DB Error: already exists

UPDATE civicrm_line_item li
LEFT JOIN civicrm_price_field_value pv ON pv.id = li.price_field_value_id
SET entity_table = 'civicrm_membership', entity_id = 898
WHERE pv.membership_type_id = 3
AND contribution_id = 1493 [nativecode=1062 ** Duplicate entry 'civicrm_membership-898-1493-196-114' for key 'UI_line_item_value']

After

No errors, contribution is processed correctly.

Technical Details

Comments

I believe isSkipLineItem was introduced fairly recently, but I could not find a reference to an issue/conversation.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[kcristiano]

@mecachisenros see a9f44ff and #15142

This looks to be where and when it was added.

I've done an r-run on this without the PR and I can recreate the error. With the PR r-run succeeds.

@eileenmcnaughton any thoughts? Adding to order api makes sense to me.

[seamuslee001]

@eileenmcnaughton @monishdeb does this make sense to you people?

[eileenmcnaughton]

I think this is OK based on @kcristiano testing - I think we could 'do better' but this does fix a bug for now