[REF] refactor on nasty Dedupe function

[eileenmcnaughton]

Overview

Minor refactoring

Before

Code hell

After

Yeah, still pretty bad.

Technical Details

I found with other pieces of refactoring static functions that creating a class to support the refactor
made it much easier as that way I could leverage the fact thatt classes have properties and
get away from the crazy param passing that characterizes a nest of static functions.

This adds a class for that purpose and moves a small chunk of code handling into the class.

The goal is to move the handling is done purely for the form back onto the form....

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS I did a quick merge test with "related tables" groups/tags/contributions.
• Developer standards
  • [r-tech] PASS
  • [r-code] PASS
    • Walked it through and it looks good, just not sure about the casting to int at line 1318. Are they sometimes not ints? Relatedly the docblock for the getter/setter says "mixed" but should be "int", unless they are mixed sometimes?
  • [r-maint] Unknown
  • [r-test] PASS