dev/core#183 CRM/Dedupe/BAO/QueryBuilder/IndividualUnsupervised.php report to using CRM_Utils…

[seamuslee001]

…_SQL_TempTable

Overview

This converts temporary table syntax to using CRM_Utils_SQL_TempTable interface in CRM/Dedupe files

Before

Legacy format used

After

CRM_Utils_SQL_TempTable used

ping @eileenmcnaughton @totten @monishdeb

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Using $this when not in object context :-(

[eileenmcnaughton]

@seamuslee001 the reason the above doesn't cause a test fail is it is never hit I believe - testBatchMergeEmailOnHold should otherwise fail

[eileenmcnaughton]

OK - the function comments re-inforce it not being called

"An alternative version which might perform a lot better

• than the above. Will need to do some testing"

And we can see the only place the class is called

[seamuslee001]

@eileenmcnaughton ok pushed up to remove that function now

[eileenmcnaughton]

OK - trying to test to see if the other is hit #15827 -

[eileenmcnaughton]

Well that's bad news - the tests don't hit it. I'm good with the function removal but need to dig more on the other

[seamuslee001]

Jenkins re test this please

[seamuslee001]

@eileenmcnaughton now that we have merged #15849 are you good with this now?

[eileenmcnaughton]

Ok - merge on pass as the code now gets a test pass-through

[seamuslee001]

Test fail unrelated

[magnolia61]

I hit a fatal error with this PR applied.

[code] => -5
[message] => DB Error: already exists
[mode] => 16
[debug_info] => CREATE TEMPORARY TABLE `civicrm_tmp_e_dedupe_7f4acdb4ca55e07e7c552114c5a75b12` ENGINE=InnoDB DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci AS SELECT * FROM civicrm_tmp_e_dedupe_ad86ee0bed80712470ca464e8d7108a4 WHERE weight >= 20 [nativecode=1050 ** Table 'civicrm_tmp_e_dedupe_7f4acdb4ca55e07e7c552114c5a75b12' already exists]
[type] => DB_Error
[user_info] => CREATE TEMPORARY TABLE `civicrm_tmp_e_dedupe_7f4acdb4ca55e07e7c552114c5a75b12` ENGINE=InnoDB DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci AS SELECT * FROM civicrm_tmp_e_dedupe_ad86ee0bed80712470ca464e8d7108a4 WHERE weight >= 20 [nativecode=1050 ** Table 'civicrm_tmp_e_dedupe_7f4acdb4ca55e07e7c552114c5a75b12' already exists]
[to_string] => [db_error: message="DB Error: already exists" code=-5 mode=callback callback=CRM_Core_Error::handle prefix="" info="CREATE TEMPORARY TABLE `civicrm_tmp_e_dedupe_7f4acdb4ca55e07e7c552114c5a75b12` ENGINE=InnoDB DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci AS SELECT * FROM civicrm_tmp_e_dedupe_ad86ee0bed80712470ca464e8d7108a4 WHERE weight >= 20 [nativecode=1050 ** Table 'civicrm_tmp_e_dedupe_7f4acdb4ca55e07e7c552114c5a75b12' already exists]"]

)

[seamuslee001]

are there any other associated errors?

[magnolia61]

I was able to retrieve a fatal error on the sandbox as well.