dev/core#183 Convert Logging report summary report to using CRM_Utils…

[seamuslee001]

…_SQL_TempTable

Overview

This converts the temporary table created in the logging summary report to using CRM_Utils_SQL_TempTable

Before

Legacy Method used

After

CRM_Utils_SQL_TempTable interface used

ping @eileenmcnaughton @totten the comments suggest there is a unit test that backs up this report

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Test fails relate there and they are:

api_v3_ReportTemplateTest.testReportTemplateGetRowsAllReports with data set #37
api_v3_ReportTemplateTest.testReportTemplateGetRowsAllReportsACL with data set #37
api_v3_ReportTemplateTest.testReportTemplateGetStatisticsAllReports with data set #37
api_v3_ReportTemplateTest.testReportsCustomDataOrderBy with data set #1
api_v3_ReportTemplateTest.testReportsCustomDataOrderBy with data set #2
api_v3_ReportTemplateTest.testReportsCustomDataOrderBy with data set #3
api_v3_ReportTemplateTest.testLoggingReportWithHookRemovalOfCustomDataTable

[pfigel]

LGTM.

• General standards
  • (r-explain) PASS
  • (r-user) PASS: No user-visible changes
  • (r-doc) PASS
  • (r-run) PASS: Applied various contact changes and confirmed the report still renders correctly. Revert still works. Test with separate CIVICRM_LOGGING_DSN was a pass as well.
• Developer standards
  • (r-tech) PASS: Standardizes on shared util function
  • (r-code) PASS
  • (r-maint) PASS
  • (r-test) PASS: Has existing test coverage

[eileenmcnaughton]

Thanks @pfigel