Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#183 Convert Include group / exclude group and include tags /… #15821

Merged

Conversation

seamuslee001
Copy link
Contributor

… exclude tags custom search to using CRM_Utils_SQL_TempTable interface

Overview

Title says it all

Before

Legacy way of creating temporary tables used

After

CRM_Utils_SQL_TempTable used

ping @eileenmcnaughton @totten

… exclude tags custom search to using CRM_Utils_SQL_TempTable interface
@civibot
Copy link

civibot bot commented Nov 11, 2019

(Standard links)

@civibot civibot bot added the master label Nov 11, 2019
@demeritcowboy
Copy link
Contributor

  • General standards
    • [r-explain] PASS
    • [r-user] PASS
    • [r-doc] PASS
    • [r-run] PASS
      • Works.
  • Developer standards
    • [r-tech] PASS
    • [r-code] PASS
    • [r-maint] PASS
    • [r-test] PASS
      • Note that there is an impressive existing unit test for this custom search. While it doesn't directly test the from() function which is what is being updated by the PR (skipped test), it does test it indirectly when it calls all().

@eileenmcnaughton eileenmcnaughton merged commit cc58f6c into civicrm:master Nov 20, 2019
@eileenmcnaughton eileenmcnaughton deleted the dev_core_183_custom_group branch November 20, 2019 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants