Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes - addresses more invalid setup data #15802

Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Nov 11, 2019

Overview

Addresses (for one test) an issue where we are creating invalid set up data for Authorize.net tests

Before

Tests butchering membership line item creations

After

Test (one so far) using new Order api based fn

Technical Details

Comments

@civibot
Copy link

civibot bot commented Nov 11, 2019

(Standard links)

@civibot civibot bot added the master label Nov 11, 2019
@eileenmcnaughton eileenmcnaughton force-pushed the complete_order_to_calling branch 3 times, most recently from 76c15f1 to 459fc2b Compare November 11, 2019 00:12
The tests were munging the line items in set up - this fixes it - but only for one so far
@eileenmcnaughton eileenmcnaughton force-pushed the complete_order_to_calling branch from 459fc2b to 7aeb7f0 Compare November 11, 2019 00:50
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 test only pr

@seamuslee001
Copy link
Contributor

Only affects tests Jenkins is the real task master here, they are clearly happy merging

@seamuslee001 seamuslee001 merged commit 3bba381 into civicrm:master Nov 11, 2019
@seamuslee001 seamuslee001 deleted the complete_order_to_calling branch November 11, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants