Remove unused parameter recur from CompleteOrder signature #15800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
| @@ -134,14 +134,6 @@ public function recur(&$input, &$ids, &$objects, $first) { | |||
|
|
|||
| $now = date('YmdHis'); | |||
|
|
|||
| // fix dates that already exist | |||
There was a problem hiding this comment.
We haven't needed to reformat get-dao for save-dao for years now
We've been pretty clear this should always be called via the api so I'm not worried about calling functions outside core being affected. I've discoverred that A.net is creating borked transactions so trying to break this down & fix
eileenmcnaughton
force-pushed
the
anet_valid
branch
from
0307e78 to
27d10f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor tidy up affecting Authorize.net IPN - remove an unused parameter, stop doing date wrangling we haven't needed in years
Before
Less readable
After
More readable
Technical Details
We've been pretty clear this should always be called via the api so I'm not worried about
calling functions outside core being affected.
I've discovered that A.net is creating borked transactions so trying to break this down & fix
Also the removed date wrangling is from when the DAO could not save dates in the same format it retrieved from the DB with - we fixed that a while back
Comments