Contribution url params - add contribution_page_id as a supported url parameter

[eileenmcnaughton]

Overview

Makes it possible to put contribution_page_id=1 as a search param, deprecates the old variant

Before

contribution_page_id=1 does not work

After

contribution_page_id=1 does work

Technical Details

Part of a generalised standardisation

Comments

I'm not planning on doing more conversions on this page at the moment - I did this primarily in the context of auditing for civicrm/civicrm-user-guide#420

@seamuslee001 this highlights a formatting issue ... oh - it's not select-2 by default - I don't like that!

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 @colemanw should we be defining 'Select2' in the xml for contribution page ID? I guess it makes sense but it feels like one everything will be & is_select2 would make more sense

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass
  • (r-doc) Pass
  • (r-run) Pass tested the search and confirmed it works,
• Developer standards
  • (r-tech) Pass - However want to hear from Coleman on the select2 matter
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass

Added Merge ready flag to give Coleman a chance to comment re select2

[seamuslee001]

I'm going to merge this now