Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconPicker widget improvements #15760

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 7, 2019

Overview

Fixes some style issues with the icon picker widget and adds some controls to the dialog.

Before

Icon inside form widget was misaligned:
image

Controls for rotating & clearing the icon were in the widget but not in the dialog:
image

After

Fixed alignment:
image

Controls are still part of the widget but are now also at the top of the dialog:
image

Comments

I added the controls to the dialog because there are several UIs that now use a more compact widget and there isn't room for the controls there. For example the icon picker in the ContactLayout editor is just an icon with a dashed box around it, so the only place to stick those controls is in the dialog.
image

@civibot
Copy link

civibot bot commented Nov 7, 2019

(Standard links)

@civibot civibot bot added the master label Nov 7, 2019
@colemanw
Copy link
Member Author

@civicrm-builder retest this please

@eileenmcnaughton
Copy link
Contributor

Just looking at this & it seems to be very narrowly scoped to me so I don't anticipate impacts outside the specific widget being altered so I don't think this should negatively impact on anyone.

Change is an improvement

@eileenmcnaughton eileenmcnaughton merged commit 41de5d4 into civicrm:master Jan 30, 2020
@eileenmcnaughton eileenmcnaughton deleted the iconPicker branch January 30, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants