Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes some style issues with the icon picker widget and adds some controls to the dialog.
Before
Icon inside form widget was misaligned:
Controls for rotating & clearing the icon were in the widget but not in the dialog:
After
Fixed alignment:
Controls are still part of the widget but are now also at the top of the dialog:
Comments
I added the controls to the dialog because there are several UIs that now use a more compact widget and there isn't room for the controls there. For example the icon picker in the ContactLayout editor is just an icon with a dashed box around it, so the only place to stick those controls is in the dialog.