[REF] minor refactor towards removing complexity. #15593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change actually makes the foreach & if following it redundant. I left them out for legibility but basically all the wrangling is on the 'other' contact. We do just one thing with the 'main' contact so the whole foreach & if is silly. Will follow up with removal of those
|
(Standard links)
|
|
unrelated fail |
|
test this please |
colemanw
reviewed
Oct 24, 2019
| $rows["move_$field"]['main'] = self::getFieldValueAndLabel($field, $main)['label']; | ||
| $rows["move_$field"]['other'] = self::getFieldValueAndLabel($field, $other)['label']; | ||
|
|
||
| foreach (['other' => $other] as $moniker => $contact) { |
There was a problem hiding this comment.
Err, this is a foreach with only one item in the array, followed by a conditional checking to see if we are looping on the one and only item. Surely both of those can be eliminated now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code legibility improvement.
Before
Less readable
After
More readable.
Technical Details
This change actually makes the foreach & if following it redundant. I left them out for legibility
but basically all the wrangling is on the 'other' contact. We do just one thing with the 'main'
contact so the whole foreach & if is silly. Will follow up with removal of those
Comments