(dev/event#15) Fix regression in handling of post profiles in email #15380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
The message templates use this loop:
```
{foreach from=$customPost item=customPos key=j}
<tr> <th {$headerStyle}>{$customPost_grouptitle.$j}</th></tr>
```
Note that the keys in `$customPost` and `$customPost_grouptitle` need to
match.
|
I confirmed (
The third commit gets the headers going again:
|
totten
changed the title
|
Filled-in description |
The unit-test suite includes cases in which the value is actually NULL.
|
Updated to pass unit-test. Manually |
|
MOP was previously given over MM from @seamuslee001 / @eileenmcnaughton . The last failure appears unrelated, so I'd call it passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a regression from 5.17.0 when sending a confirmation email. If event uses any "post" profile forms, then the confirmation email includes subsections to summarize each post-profile. The subsection titles were miscomputed. This manifested as either a page crash or an inaccurate title.
See also: https://lab.civicrm.org/dev/event/issues/15
Before
After
Technical Details
The previous code took an array (
$postProfileID) and casted it to anint. This produced an arbitrary int (0or1). The revised code handles the array as an array.