dev/core#1291 Use name instead of label to check contribution status

[mattwire]

Overview

This will fail if the label is changed (eg. different language). Now it won't.

https://lab.civicrm.org/dev/core/issues/1291

Before

Check label

After

Check name

Technical Details

Need to check name not label.

Comments

@mlutfy This is similar to other translation fixes you've done - can you check?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mlutfy]

Seems OK on code review. How can I reproduce?

[mattwire]

@mlutfy I'm not sure how you could reproduce - I just came across it when tracing another issue and thought "that will cause problems".

[jitendrapurohit]

Agree with the change made here. It looks like this file was recently changed and refactored here - https://github.com/civicrm/civicrm-core/pull/15124/files. This PR seems to revert that line to correctly retrieve the status value by name. +1 to get this merged

[mlutfy]

Merging based on Jitendra's review, and also on #15391 from @samuelsov.