dev/core#1255 - fix display of email address on pay later contribution #15314
Conversation
|
(Standard links)
|
jitendrapurohit
force-pushed
the
dev-1255
branch
from
40cef32 to
ceba7a8
Compare
|
Jenkins test this please |
| if ($this->_emailExists && empty($this->_params["email-{$this->_bltID}"])) { | ||
| foreach ($this->_params as $key => $val) { | ||
| if (substr($key, 0, 6) == 'email-') { | ||
| $this->assign('email', $this->_params[$key]); | ||
| } | ||
| } | ||
| } | ||
| else { | ||
| $this->assign('email', CRM_Utils_Array::value("email-{$this->_bltID}", $this->_params)); | ||
| } |
There was a problem hiding this comment.
@jitendrapurohit Can you extract this bit of code into it's own function and provide a comment explaining why we have to do it this way?
|
@jitendrapurohit You might want to move the code in its own method as suggested by Matt. |
|
@jitendrapurohit Will you able to extract this code as a separate method and we can merge this bug fix :) |
jitendrapurohit
force-pushed
the
dev-1255
branch
from
ceba7a8 to
d90e6c3
Compare
|
Has anyone tested this @mattwire @yashodha @eileenmcnaughton? If yes, can we merge? |
|
FYI it looks like someone on stackexchange tested it and said it worked: https://civicrm.stackexchange.com/questions/34284/an-email-confirmation-with-these-payment-instructions-has-been-sent-to |
|
Looks good merging as per the positive feedback on stack exchange |
Overview
Fix for email address token on the confirmation message not working for a pay later contribution
Before
Email address is not displayed on the Thankyou screen. To replicate -
The second line ends with "has been sent to .". This should be displaying an email address of the user.
After
The confirmation message displays an email address correctly.
Comments
Gitlab link - https://lab.civicrm.org/dev/core/issues/1255