Fix for core#1247 - export hook doesn't work #15287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
my only question @MegaphoneJon @eileenmcnaughton is do we need to set back the Columns and headers array back onto the processor after the hook or does it not matter. Also i don't want to see that being a blocker to this going through |
|
@seamuslee001 it's just about ready to exit at that point |
| CRM_Utils_Hook::export($exportTempTable, $headerRows, $sqlColumns, $exportMode, $componentTable, $ids); | ||
| if ($exportMode !== $this->getExportMode() || $componentTable !== $this->getComponentTable()) { | ||
| CRM_Core_Error::deprecatedFunctionWarning('altering the export mode and/or component table in the hook is no longer supported.'); |
There was a problem hiding this comment.
@MegaphoneJon so per your discussion it's kinda meaningless to change ids & we are assuming it's safe to be clear about that - shall we change the hook to no longer accept $ids as a reference? (could be in master)
|
Looks right to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Export hooks no longer work.
Before
Export hooks don't work.
After
Export hooks work.
Technical Details
#14913 moved the line that calls the hook to a place where the hook's arguments are mostly not defined. This defines the arguments.
Comments
We're deprecating passing some arguments by reference, because this hook is called too late in the process for the changed values to have any meaning.
The original PR against master is #15266, some good discussion there.