dev/core#1246 fix fatal error on search builder if a core contact type is disabled. #15279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is disabled. Per my comments on the ticket & in the code I'm not convinced disabling a core type is supported but it seems easy enough to get past the reported bug https://lab.civicrm.org/dev/core/issues/1246
|
(Standard links)
|
|
@eileenmcnaughton I tested this and still got errors on search builder without Households enabled. So I've done a more thorough patch which removes some hard-coded assumptions about contact types in the code. See #15284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes fatal error when loading search builder if core contact type Household or Organizationis disabled
Before
Fatal error
After
Loads
Technical Details
Per my comments on the ticket & in the code I'm not convinced disabling a core type is supported
but it seems easy enough to get past the reported bug
https://lab.civicrm.org/dev/core/issues/1246
Comments