dev/core#1240 Ensure that Options are not duplicated when saving a co… #15245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
commented
Sep 7, 2019
| 'label' => 'Contribution Amount', | ||
| 'html_type' => 'Radio', | ||
| 'financial_type_id' => 1, | ||
| 'option_label' => [ |
There was a problem hiding this comment.
This is the strange format that is used when saving the fees / options from the UI
…ntribution or event page when specifying the options
seamuslee001
force-pushed
the
lab_core_1240
branch
from
3cbfa3f to
94f5d03
Compare
|
I applied this patch on our production sites and so far so good. I also did a fair amount of random testing on the PR test site, and it looks good too. I also tested non-quick pricesets. +1 awesome responsiveness +1 has tests |
|
merging based on @mlutfy testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntribution or event page when specifying the options
Overview
This fixes an issue where re-saving the amounts screen for a contribution page or the fees one for an event page where your specifying the fees or amounts on that screen rather than using an already generated price set causes the options to be duplicated
Before
Options are duplicated
After
Options are not duplicated
Note that this only affects the RC not 5.17
ping @mlutfy @eileenmcnaughton