Use metadata for dataPatterns #15224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This is a bit harder to add a test for than columnHeaders but the principle of the change is very much the same so I'm thinking it can get a free ride on that test
eileenmcnaughton
force-pushed
the
headers
branch
from
a905ddf to
5d9b686
Compare
|
Ok I traced through the code and it makes sense. |
|
And now your head hurts.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Further minor cleanup - switch to metadata
Before
Less readable
After
More readable
Technical Details
This is a bit harder to add a test for than columnHeaders ( #15220) but the principle of the change is very much the
same so I'm thinking it can get a free ride on that test
Comments