Re-remove pledge & member fields from the legacy date list #15200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
agree adding MOP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per #15194 we now need a list of legacy dates in this function to ensure correct saving. This removes the fields that were merged to 5.17 as legacy dates but which are no longer legacy in 5.18
Before
No-longer-legacy dates mistreated as legacy
After
Fixed
Technical Details
This is a follow up on the conversion of legacy dates for pledge & member fields
Comments
@seamuslee001
Also I think 5.16 needs contribution_recur fields in this list but they are converted in 5.17