dev/core#1190 Add pptx to safe file types #15047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -677,6 +677,7 @@ VALUES | |||
| (@option_group_id_sfe, 'xlsx', 13, 'xlsx', NULL, 0, 0, 13, NULL, 0, 0, 1, NULL, NULL, NULL), | |||
| (@option_group_id_sfe, 'odt', 14, 'odt', NULL, 0, 0, 14, NULL, 0, 0, 1, NULL, NULL, NULL), | |||
| (@option_group_id_sfe, 'ics', 15, 'ics', NULL, 0, 0, 15, NULL, 0, 0, 1, NULL, NULL, NULL), | |||
| (@option_group_id_sfe, 'pptx', 16, 'pptx', NULL, 0, 0, 16, NULL, 0, 0, 1, NULL, NULL, NULL), | |||
There was a problem hiding this comment.
@eileenmcnaughton i think we would need to run ./bin/regen.sh as we are changing what should be in civicrm_generated.mysql file
There was a problem hiding this comment.
@seamuslee001 ok - updated
eileenmcnaughton
force-pushed
the
pptx
branch
2 times, most recently
from
b8200ea to
4743277
Compare
I feel like it would be better to store these as an array somewhere - maybe as the first step to a metadata construct for Option groups...
|
@pfigel are you ok with this? |
|
Note that per the ticket this should be the same risk level as docx - ie. 'std Microsoft risk level' .... |
Agreed. |
|
Merging based on Patrick's comment and the fact we already list docx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the last security release we added a whitelist for uploadable file types - this missed some common types. We previously added ics & this add pptx
Before
pptx files cannot be uploaded
After
They are in the whitelist
Technical Details
I feel like it would be better to store these as an array somewhere - maybe as the first step to
a metadata construct for Option groups...
Comments
I guess some more of these will pop up - we can maybe treat any found within 6 months of the change as 'regressions'
https://lab.civicrm.org/dev/core/issues/1190