[NFC] dev/core#1116 - seek and document where activityTypeName is name and where it's label

[demeritcowboy]

Overview

This is part of a series. See also #14952

Before

Unused var

After

Still unused, but noted.

Technical Details

activityTypeName used to be used in ActivityView.tpl but was removed in

https://github.com/civicrm/civicrm-core/blame/06b69b1899b6304f7832f6d4d2f5af4a0acfde8c/templates/CRM/Activity/Form/ActivityView.tpl#L26

and

b0a72b3

Comments

It's possible it's still used in a customized override somewhere by somebody. But I couldn't find a reference in core or a reference where the tpl was {include}'d anywhere. I'm guessing it was just left during the rearrangement above. But it's commented now.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).