Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/drupal#72 fix display of profiles on events to use front end titles #14958

Closed
wants to merge 2 commits into from

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 4, 2019

Overview

Fixes Event Confirm & Event Thank you to display front end profile titles (where configured)

Before

Register ...
Screen Shot 2019-08-05 at 7 00 29 AM

BUT
Screen Shot 2019-08-05 at 7 00 51 AM

After

Screen Shot 2019-08-05 at 8 03 46 AM

Screen Shot 2019-08-05 at 8 04 10 AM

Technical Details

If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary

Comments

https://lab.civicrm.org/dev/drupal/issues/72

@civibot
Copy link

civibot bot commented Aug 4, 2019

(Standard links)

@civibot civibot bot added the master label Aug 4, 2019
@eileenmcnaughton eileenmcnaughton changed the title Event prof dev/drupal#72 fix display of profiles on events to use front end titles Aug 4, 2019
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 did I ping you about this - I'm not actually vested in it - my main focus was to increase test cover prior to attempting to fix more complicated issues

@eileenmcnaughton
Copy link
Contributor Author

this is a sub-pr of #14960 - I was going to rebase that once this was merged but it seems that will be merged & this will be closed

@eileenmcnaughton
Copy link
Contributor Author

Merged as part of #14960

@eileenmcnaughton eileenmcnaughton deleted the event_prof branch October 3, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant