[REF] [Test] [Export] Convert some more tests to use the newer function #14933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
In testing this I checked and all the exports export an integer in the campaign_id field. Contribution ALSO exports campaign_title field - which is unaffected by the removed lines (& for contribution both are tested) I see the reference to https://issues.civicrm.org/jira/browse/CRM-14398 is for contribution which is covered by the unit test
eileenmcnaughton
force-pushed
the
export_test
branch
from
82cfeff to
07b892f
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Converts some tests to new helper & also cleans up special handling on campaign_id fields
Before
Uses old helper, unnecessary handling
After
New helper, handling removed
Technical Details
In testing this I checked and all the exports export an integer in the campaign_id field. Contribution
ALSO exports campaign_title field - which is unaffected by the removed lines (& for contribution both are tested)
I see the reference to https://issues.civicrm.org/jira/browse/CRM-14398 is for contribution which is covered by the unit test
Comments